tests/Feature/Controllers/SearchIncludingRelationshipsOperationsTest.php (1)

584-645: Add test coverage for models without the eager-loaded relation.

The test only creates one model with the full relation chain. However, the PR objective is to fix eager loading for search operations, and the AI summary mentions normalizing null results to empty arrays. Similar tests in this file (e.g., test_getting_a_list_of_resources_including_has_many_relation at lines 534-582) create two models—one with relations and one without—to verify both scenarios.

Consider adding a second model without the relation to ensure the fix properly handles the case where hasManyRelationWithEagerLoadingRelation returns an empty result.

Apply this diff to add coverage for the edge case:

     public function test_getting_a_list_of_resources_including_has_many_relation_with_eager_loading_relations(): void
     {
         $matchingModel = ModelFactory::new()
             ->createOne()->fresh();
 
         $hasMany = HasManyRelationFactory::new()
             ->for($matchingModel)
             ->createOne();
 
         HasManyThroughRelationFactory::new()
             ->for($hasMany)
             ->createOne();
+
+        $matchingModel2 = ModelFactory::new()->createOne()->fresh();
 
         Gate::policy(Model::class, GreenPolicy::class);
         Gate::policy(HasManyRelation::class, GreenPolicy::class);
         Gate::policy(HasManyThroughRelation::class, GreenPolicy::class);
 
         $response = $this->post(
             '/api/models/search',
             [
                 'search' => [
                     'includes' => [
                         [
                             'relation' => 'hasManyRelationWithEagerLoadingRelation',
                         ],
                     ],
                 ],
             ],
             ['Accept' => 'application/json']
         );
 
         $this->assertResourcePaginated(
             $response,
-            [$matchingModel],
+            [$matchingModel, $matchingModel2],
             new ModelResource(),
             [
                 [
                     'has_many_relation_with_eager_loading_relation' => $matchingModel->hasManyRelationWithEagerLoadingRelation()
                         ->orderBy('id')
                         ->get()
                         ->map(function ($relation) {
                             $relation->has_many_through_relation = $relation->hasManyThroughRelation
                                 ->map(function ($relation) {
                                     $relation->has_many_relation = $relation->hasManyRelation->only(
                                         (new HasManyResource())->getFields(app()->make(RestRequest::class))
                                     );
 
                                     return $relation->only(array_merge(
                                         (new HasManyThroughResource())->getFields(app()->make(RestRequest::class)),
                                         ['has_many_relation']
                                     ));
                                 })->toArray();
 
                             return $relation->only(array_merge(
                                 (new HasManyResource())->getFields(app()->make(RestRequest::class)),
                                 ['has_many_through_relation']
                             ));
                         })->toArray(),
                 ],
+                [
+                    'has_many_relation_with_eager_loading_relation' => [],
+                ],
             ]
         );
     }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro